linux-kernel - Re: [PATCH 1/3] usbip: only dump valid port status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2011 14:42:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	Németh Márton <nm127@...email.hu>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Matt Mooney <mfm@...eddisk.com>,
	Max Vozeler <max@...terhof.net>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	usbip-devel@...ts.sourceforge.net, devel@...verdev.osuosl.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] usbip: only dump valid port status

On Mon, 2011-06-13 at 23:29 +0200, Németh Márton wrote:
> From: Márton Németh <nm127@...email.hu>
> 
> The wIndex parameter of vhci_hub_control() is always zero when the
> request type is GetHubDescriptor,
> ---
> diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
> @@ -464,8 +464,11 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> 
>  	if (usbip_dbg_flag_vhci_rh) {
>  		pr_debug("port %d\n", rhport);
> -		dump_port_status(prev_port_status[rhport]);
> -		dump_port_status(dum->port_status[rhport]);
> +		/* Only dump valid port status */
> +		if (0 <= rhport) {
> +			dump_port_status(prev_port_status[rhport]);
> +			dump_port_status(dum->port_status[rhport]);
> +		}
>  	}
>  	usbip_dbg_vhci_rh(" bye\n");
> 

Linux relatively rarely uses constant before variable in a comparison.
ie: please use "if (rhport > 0)" instead


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/