linux-kernel - two false alarms from checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <E18F441196CA634DB8E1F1C56A50A874572DE7E95F@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Mon, 13 Jun 2011 16:18:06 -0700
From:	"Jian Peng" <jipeng@...adcom.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
cc:	"Jian Peng" <jipeng@...adcom.com>
Subject: two false alarms from checkpatch.pl

After running "./scripts/checkpatch.pl -F arch/mips/kernel/syscall.c", I got some errors reported on valid lines

ERROR: space prohibited before open square bracket '['
#451: FILE: mips/kernel/syscall.c:451:
+		: [addr] "r" (addr),

This line is valid, and if I remove the space in between, it will report a different error

ERROR: spaces required around that ':' (ctx:ExV)
#448: FILE: mips/kernel/syscall.c:448:
+		:[old] "=&r" (old),
 		^

In another case, it reported

ERROR: trailing statements should be on next line
#515: FILE: mips/kernel/syscall.c:515:
+	while (1);

This is also valid line.

The above two cases are both false alarms, and need to be treated as exceptions in "checkpatch.pl -F".

Thanks,
Jian



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/