linux-kernel - RE: two false alarms from checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E18F441196CA634DB8E1F1C56A50A874572DE7E973@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Mon, 13 Jun 2011 16:28:36 -0700
From:	"Jian Peng" <jipeng@...adcom.com>
To:	"Joe Perches" <joe@...ches.com>
cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Jian Peng" <jipeng@...adcom.com>
Subject: RE: two false alarms from checkpatch.pl

Hi, Joe,

I can ignore both. On the other hand, 

while (1); 

is a style that was used universally by C programmers. Could you rethink about take this as exception in checkpatch.pl?

Thanks,
Jian

-----Original Message-----
From: Joe Perches [mailto:joe@...ches.com] 
Sent: Monday, June 13, 2011 4:24 PM
To: Jian Peng
Cc: linux-kernel@...r.kernel.org
Subject: Re: two false alarms from checkpatch.pl

On Mon, 2011-06-13 at 16:18 -0700, Jian Peng wrote:
> After running "./scripts/checkpatch.pl -F arch/mips/kernel/syscall.c", I got some errors reported on valid lines
> 
> ERROR: space prohibited before open square bracket '['
> #451: FILE: mips/kernel/syscall.c:451:
> +		: [addr] "r" (addr),
> 
> This line is valid, and if I remove the space in between, it will report a different error
> 
> ERROR: spaces required around that ':' (ctx:ExV)
> #448: FILE: mips/kernel/syscall.c:448:
> +		:[old] "=&r" (old),
>  		^
> In another case, it reported

Known defect.  checkpatch doesn't correctly parse asm.
checkpatch output isn't dicta.
You should just ignore it.

> ERROR: trailing statements should be on next line
> #515: FILE: mips/kernel/syscall.c:515:
> +	while (1);
> 
> This is also valid line.

That's really not a kernel style conformant line.

It really should be written as something like:

	while (1) {
		;		/* Never exit */
	}