linux-kernel - Re: [PATCH 3/3] alpha, drm: Add Alpha support to Radeon DRM code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2011 09:35:30 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Jay Estabrook <jay.estabrook@...il.com>
Cc:	linux-alpha <linux-alpha@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Matt Turner <mattst88@...il.com>,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>, airlied@...ux.ie
Subject: Re: [PATCH 3/3] alpha, drm: Add Alpha support to Radeon DRM code

On Fri, Jun 10, 2011 at 8:20 AM, Jay Estabrook <jay.estabrook@...il.com> wrote:
>
> Alpha needs to have the system bus address for the device's local
> memory available, so that it can be returned to user-level, where
> it may be used in an mmap(). So, we make bus.addr hold the ioremap()
> return for kernel use, and then we can modify bus.base appropriately.
>

I don't get this. why is mmap passing in an address? we don't do that anymore.

When you mmap the device node it passes back a hashed offset in the
table, that the
kernel then translates into a proper address and sets up the page tables.

So I really don't get what this patch is doing, either the
explaination of what it is doing is wrong
or it is wrong.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/