linux-kernel - Re: [PATCH] sound: Fix beep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htybudvhk.wl%tiwai@suse.de>
Date:	Mon, 13 Jun 2011 09:46:31 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: Fix beep_device compilation warnings

At Sun, 12 Jun 2011 13:02:43 -0700,
Joe Perches wrote:
> 
> Using static inline functions can reduce compilation messages
> and macro misuse.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> ---
> 
> Maybe this helps?
> 
> On Sun, 2011-06-12 at 21:40 +0200, Borislav Petkov wrote:
> > Btw, I keep noticing those when building on 32bit:
> > sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5045’:
> > sound/pci/hda/patch_conexant.c:1232:3: warning: statement with no effect
> > sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5051’:
> > sound/pci/hda/patch_conexant.c:2067:3: warning: statement with no effect
> > sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5066’:
> > sound/pci/hda/patch_conexant.c:3261:3: warning: statement with no effect
> > sound/pci/hda/patch_conexant.c: In function ‘patch_conexant_auto’:
> > sound/pci/hda/patch_conexant.c:4370:3: warning: statement with no effect

Yep, this must be.  Now applied.
Thanks!


Takashi

> 
>  sound/pci/hda/hda_beep.h |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_beep.h b/sound/pci/hda/hda_beep.h
> index f1de1ba..4967eab 100644
> --- a/sound/pci/hda/hda_beep.h
> +++ b/sound/pci/hda/hda_beep.h
> @@ -50,7 +50,12 @@ int snd_hda_enable_beep_device(struct hda_codec *codec, int enable);
>  int snd_hda_attach_beep_device(struct hda_codec *codec, int nid);
>  void snd_hda_detach_beep_device(struct hda_codec *codec);
>  #else
> -#define snd_hda_attach_beep_device(...)		0
> -#define snd_hda_detach_beep_device(...)
> +static inline int snd_hda_attach_beep_device(struct hda_codec *codec, int nid)
> +{
> +	return 0;
> +}
> +void snd_hda_detach_beep_device(struct hda_codec *codec)
> +{
> +}
>  #endif
>  #endif
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/