linux-kernel - Re: [PATCH] efifb: Fix call to wrong unregister function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110614073341.GG17891@linux-sh.org>
Date:	Tue, 14 Jun 2011 16:33:42 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Andy Lutomirski <luto@....EDU>
Cc:	"wanlong.gao" <wanlong.gao@...il.com>,
	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
	Maarten Lankhorst <m.b.lankhorst@...il.com>,
	Peter Jones <pjones@...hat.com>
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function

On Sun, Jun 12, 2011 at 10:55:37PM -0400, Andy Lutomirski wrote:
> On 06/12/2011 06:52 AM, wanlong.gao wrote:
> ><snip>
> >
> >Hi Maarten:
> >It registered efifb_device but try to unregistered efifb_driver,
> >so I think you should fix it like this?
> >
> >Signed-off-by: Wanlong Gao<wanlong.gao@...il.com>
> >---
> >  drivers/video/efifb.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> >index 69c49df..784139a 100644
> >--- a/drivers/video/efifb.c
> >+++ b/drivers/video/efifb.c
> >@@ -541,7 +541,7 @@ static int __init efifb_init(void)
> >  	 */
> >  	ret = platform_driver_probe(&efifb_driver, efifb_probe);
> >  	if (ret) {
> >-		platform_device_unregister(&efifb_driver);
> >+		platform_device_unregister(&efifb_device);
> >  		return ret;
> >  	}
> >
> 
> Acked-by: Andy Lutomirski <luto@....edu>
> 
Updated version applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/