linux-kernel - Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2011 00:56:22 -0700
From:	Debashis Dutt <debdut@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Jay Cliburn <jcliburn@...il.com>,
	Chris Snook <chris.snook@...il.com>,
	Jie Yang <jie.yang@...eros.com>,
	Sathya Perla <sathya.perla@...lex.com>,
	Subbu Seetharaman <subbu.seetharaman@...lex.com>,
	Ajit Khaparde <ajit.khaparde@...lex.com>,
	Rasesh Mody <rmody@...cade.com>,
	Debashis Dutt <ddutt@...cade.com>,
	Sjur Braendeland <sjur.brandeland@...ricsson.com>,
	Divy Le Ray <divy@...lsio.com>,
	Breno Leitao <leitao@...ux.vnet.ibm.com>,
	Amit Kumar Salecha <amit.salecha@...gic.com>,
	Ron Mercer <ron.mercer@...gic.com>, linux-driver@...gic.com,
	Anirban Chakraborty <anirban.chakraborty@...gic.com>,
	Jon Mason <jdmason@...zu.us>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	Steve Hodgson <shodgson@...arflare.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Daniele Venzano <venza@...wnhat.org>,
	David Dillow <dave@...dillows.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

> diff --git a/drivers/net/bna/bfa_cee.c b/drivers/net/bna/bfa_cee.c
> index f7b789a..dcfbf08 100644
> --- a/drivers/net/bna/bfa_cee.c
> +++ b/drivers/net/bna/bfa_cee.c
> @@ -236,7 +236,7 @@ static void
>  bfa_cee_hbfail(void *arg)
>  {
>        struct bfa_cee *cee;
> -       cee = (struct bfa_cee *) arg;
> +       cee = arg;
>
>        if (cee->get_attr_pending == true) {
>                cee->get_attr_status = BFA_STATUS_FAILED;
> diff --git a/drivers/net/bna/cna.h b/drivers/net/bna/cna.h
> index bbd39dc..3c47dc5 100644
> --- a/drivers/net/bna/cna.h
> +++ b/drivers/net/bna/cna.h
> @@ -74,7 +74,7 @@ typedef struct mac { u8 mac[MAC_ADDRLEN]; } mac_t;
>                bfa_q_next(_q) = bfa_q_next(*((struct list_head **) _qe)); \
>                bfa_q_qe_init(*((struct list_head **) _qe));            \
>        } else {                                                        \
> -               *((struct list_head **) (_qe)) = (struct list_head *) NULL; \
> +               *((struct list_head **)(_qe)) = NULL;                   \
>        }                                                               \
>  }
>

"bna" patches look good.

Thanks
--Debashis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/