linux-kernel - Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308053362.2819.38112.camel@groo>
Date:	Tue, 14 Jun 2011 15:09:22 +0300
From:	Carlos Chinea <carlos.chinea@...ia.com>
To:	ext Tony Lindgren <tony@...mide.com>
Cc:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver

Hi,
-- cut--
> > +
> > +static int __init ssi_init(void)
> > +{
> > +	return platform_device_register(&ssi_pdev);
> > +}
> > +subsys_initcall(ssi_init);
> 
> Looks like you need something here also to prevent this subsys_initcall
> on running on all boards. Maybe have a pointer to ssi_pdev that only
> gets initialized after omap_ssi_config?
> 
> Then you can have ssi_init fail if no configuration is called:
> 
> 	if (!pdev)
> 		return -ENODEV;
> 
> 	return platform_device_register(pdev);
> 

Right. I'll do those changes.

Thanks,
Carlos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/