linux-kernel - Re: [V9fs-developer] [PATCH 3/3] 9p: add 9P2000.L unlinkat operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikn+O0P6SOhR0r7hCNP_U45iQ6-dQ@mail.gmail.com>
Date:	Tue, 14 Jun 2011 10:14:55 -0500
From:	Eric Van Hensbergen <ericvh@...il.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	v9fs-developer@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [V9fs-developer] [PATCH 3/3] 9p: add 9P2000.L unlinkat operation

On Tue, Jun 14, 2011 at 1:59 AM, Aneesh Kumar K.V
<aneesh.kumar@...ux.vnet.ibm.com> wrote:
> On Mon, 13 Jun 2011 16:12:52 -0500, Eric Van Hensbergen <ericvh@...il.com> wrote:
>> Could be wrong, but a quick regression check of your patches fails
>> against a legacy server.  Are you making sure the new operations are
>> properly protected by a .L flag?
>
> How about below diff
>
> [3.0-pending@...s]$ git diff
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index f40fdc3..436699e 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -499,13 +499,15 @@ v9fs_inode_from_fid(struct v9fs_session_info *v9ses, struct p9_fid *fid,
>
>  static int v9fs_remove(struct inode *dir, struct dentry *dentry, int flags)
>  {
> -       int retval;
>        struct inode *inode;
> +       int retval = -EOPNOTSUPP;
>        struct p9_fid *v9fid, *dfid;
> +       struct v9fs_session_info *v9ses;
>
>        P9_DPRINTK(P9_DEBUG_VFS, "inode: %p dentry: %p rmdir: %x\n",
>                   dir, dentry, flags);
>
> +       v9ses = v9fs_inode2v9ses(dir);
>        inode = dentry->d_inode;
>        dfid = v9fs_fid_lookup(dentry->d_parent);
>        if (IS_ERR(dfid)) {
> @@ -513,7 +515,8 @@ static int v9fs_remove(struct inode *dir, struct dentry *dentry, int flags)
>                P9_DPRINTK(P9_DEBUG_VFS, "fid lookup failed %d\n", retval);
>                return retval;
>        }
> -       retval = p9_client_unlinkat(dfid, dentry->d_name.name, flags);
> +       if (v9fs_proto_dotl(v9ses))
> +               retval = p9_client_unlinkat(dfid, dentry->d_name.name, flags);
>        if (retval == -EOPNOTSUPP) {
>                /* Try the one based on path */
>                v9fid = v9fs_fid_clone(dentry);
>

Looks right.
>
> related to renameat i have updated to check for -EOPNOTSUPP instead of
> -ENOSYS. I am not sure any other dotl server out there is returning
> -ENOSYS. We haven't documented what the server should return in case it
> doesn't support any specific operation.
>

Yeah, the real tricky thing is I'm not sure what the other 9p servers
will send back since there are so many of them.  I guess for dotl all
we need to do is look at diod and see what they are returning
(however, I'm sure they'll change if we want to make EOPNOTSUPP
standard).

          -eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/