linux-kernel - Re: [PATCH v2] x86, efi: Do not reserve boot services regions within reserved areas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2011 19:26:01 +0200
From:	Maarten Lankhorst <m.b.lankhorst@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Matthew Garrett <mjg59@...f.ucam.org>,
	Yinghai Lu <yinghai@...nel.org>, Jim Bos <jim876@...all.nl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] x86, efi: Do not reserve boot services regions within
 reserved areas

Op 14-06-11 19:05, Joe Perches schreef:
> On Tue, 2011-06-14 at 18:19 +0200, Maarten Lankhorst wrote:
>> Commit 916f676f8dc started reserving boot service code since some systems
>> require you to keep that code around until SetVirtualAddressMap is called.
> []
>> Signed-off-by: Maarten Lankhorst <m.b.lankhorst@...il.com>
> Hello Maarten, just trivia.
>
>> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> []
>> +			memblock_dbg(PFX "Could not reserve boot area "
>> +				"[0x%llx-0x%llx)\n", start, start+size);
> I believe this should be:
>
> 			memblock_dbg(PFX "Could not reserve boot area 0x%llx-0x%llx)\n",
> 				     start, start + size - 1);
Erm, no. [x...y) means the range of x to y without including y.

Other efi code followed that convention, and the e820 code does the same, silently.

[    0.000000] BIOS-provided physical RAM map:
[    0.000000]  BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
...
[    0.000000] EFI: mem00: type=3, attr=0xf, range=[0x0000000000000000-0x0000000000008000) (0MB)

~Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/