| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jun 2011 10:23:01 +0200 From: Tejun Heo <tj@...nel.org> To: Péter Ujfalusi <peter.ujfalusi@...com> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, "Girdwood, Liam" <lrg@...com>, Tony Lindgren <tony@...mide.com>, Mark Brown <broonie@...nsource.wolfsonmicro.com>, Samuel Ortiz <sameo@...ux.intel.com>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "Lopez Cruz, Misael" <misael.lopez@...com> Subject: Re: Re: Re: Re: Re: [PATCH v4 11/18] input: Add initial support for TWL6040 vibrator On Wed, Jun 15, 2011 at 10:18:58AM +0200, Tejun Heo wrote: > No human being can feel 120usec difference and I can't see how using > HIGHPRI is justified here (which is what the code is doing > _accidentally_ by using singlethread_workqueue). Ooh, one more thing, and even if you insist on using HIGHPRI (please don't), you don't need to create workqueue for each device. You can just create one for the whole driver in init and destroy it from exit. What matters is the HIGHPRI attribute of the workqueue. The number of workqueues is completely irrelevant. Thank you. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists