linux-kernel - Re: [PATCH]mm: use correct address for pte_unmap_unlock in zap_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308134610.15315.35.camel@twins>
Date:	Wed, 15 Jun 2011 12:43:30 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH]mm: use correct address for pte_unmap_unlock in
 zap_pte_range

On Wed, 2011-06-15 at 18:29 +0800, Shaohua Li wrote:
> Boot an i386 kernel, I got:
> [    3.766613] WARNING: at /workshop/kernel/git/my/linux/arch/x86/mm/highmem_32.c:81 __kunmap_atomic+0x6f/0x113()
> [    3.766615] Hardware name: Studio XPS 8000
> [    3.766617] Modules linked in:
> [    3.766619] Pid: 214, comm: blkid Not tainted 3.0.0-rc3+ #529
> [    3.766621] Call Trace:
> [    3.766625]  [<c1063803>] warn_slowpath_common+0x6a/0x7f
> [    3.766628]  [<c104f494>] ? __kunmap_atomic+0x6f/0x113
> [    3.766631]  [<c106382c>] warn_slowpath_null+0x14/0x18
> [    3.766633]  [<c104f494>] __kunmap_atomic+0x6f/0x113
> [    3.766637]  [<c10e6033>] zap_pte_range+0x291/0x2b4
> [    3.766641]  [<c105a37d>] ? get_parent_ip+0xb/0x31
> [    3.766644]  [<c10e6180>] unmap_page_range+0x12a/0x147
> [    3.766647]  [<c10e6243>] unmap_vmas+0xa6/0xe2
> [    3.766650]  [<c10e7c26>] exit_mmap+0x78/0xd3
> [    3.766654]  [<c106207a>] mmput+0x39/0x99
> [    3.766657]  [<c106582f>] exit_mm+0x101/0x109
> [    3.766660]  [<c1066d83>] do_exit+0x1e6/0x312
> [    3.766664]  [<c10fff66>] ? fput+0x18/0x1a
> [    3.766666]  [<c1066f16>] do_group_exit+0x67/0x8a
> [    3.766669]  [<c1066f51>] sys_exit_group+0x18/0x1c
> [    3.766673]  [<c1620154>] syscall_call+0x7/0xb
> 
> the zap_pte_range does:
> 	pte = pte_offset_map_lock(mm, pmd, addr, &ptl);
> 	do {
> 		...
> 	             if (force_flush)
>                      	break;
> 		...
>         } while (pte++, addr += PAGE_SIZE, addr != end);
> 
>         pte_unmap_unlock(pte - 1, ptl);
> 
> the pte_unmap_unlock(pte - 1) only works if pte++ does once.
> 
> this is a regression introduced by d16dfc550f5326a4000f3(mm: mmu_gather
> rework)

Already send by Steven and picked up by Andrew:

lkml.kernel.org/r/1307158665.3667.86.camel@...dalf.stny.rr.com
lkml.kernel.org/r/201106040413.p544D9ox027032@...p1.linux-foundation.org

Apparently it hasn't made its way to Linus though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/