linux-kernel - [PATCH] dvb-usb/technisat-usb2: don't use flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110615133206.GW8141@htj.dyndns.org>
Date:	Wed, 15 Jun 2011 15:32:06 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Patrick Boettcher <pboettcher@...nellabs.com>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] dvb-usb/technisat-usb2: don't use flush_scheduled_work()

flush_scheduled_work() is deprecated and scheduled to be removed.
technisat-usb2 already sync-cancels the only work item it uses and
there's no reason for it to call flush_scheduled_work().  Don't use
it.

Signed-off-by: Tejun Heo <tj@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
Cc: Patrick Boettcher <pboettcher@...nellabs.com>
---
I was re-scanning source tree to prepare for deprecation of
flush_scheduled_work() and found out new driver added usage
unnecessarily.  Can you please include this patch so that it gets
propagated to linux-next soonish?

Thank you.

 drivers/media/dvb/dvb-usb/technisat-usb2.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: work/drivers/media/dvb/dvb-usb/technisat-usb2.c
===================================================================
--- work.orig/drivers/media/dvb/dvb-usb/technisat-usb2.c
+++ work/drivers/media/dvb/dvb-usb/technisat-usb2.c
@@ -765,10 +765,8 @@ static void technisat_usb2_disconnect(st
 	/* work and stuff was only created when the device is is hot-state */
 	if (dev != NULL) {
 		struct technisat_usb2_state *state = dev->priv;
-		if (state != NULL) {
+		if (state != NULL)
 			cancel_delayed_work_sync(&state->green_led_work);
-			flush_scheduled_work();
-		}
 	}
 
 	dvb_usb_device_exit(intf);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/