| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jun 2011 20:06:32 +0530 From: "Hiremath, Vaibhav" <hvaibhav@...com> To: Vladimir Pantelic <vladoman@...il.com>, Kernel development list <linux-kernel@...r.kernel.org> CC: "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org> Subject: RE: [PATCH] omap v4l2: fix wrong resizer calculation > -----Original Message----- > From: Vladimir Pantelic [mailto:vladoman@...il.com] > Sent: Wednesday, June 15, 2011 3:46 PM > To: Kernel development list > Cc: linux-omap@...r.kernel.org; Hiremath, Vaibhav > Subject: Re: [PATCH] omap v4l2: fix wrong resizer calculation > > ping [Hiremath, Vaibhav] Sorry for delayed response, somehow I completely missed this patch. Thanks for finding this bug, the patch looks ok to me. Only one suggestion I have is to update the description of patch commit, request you to change like following - ---- The omap_vout_new_crop() function has possible bug, uses uninitialized variable "crop.width/height" which is actually output of the function. Instead we should be using "try_crop.width/height" to calculate the resizer value. ---- Rest everything looks ok, while submitting patch again you can add my ack; I will queue to my Arago repo. Also I have tested this patch on OMAP3EVM platform, and it seems to be working fine. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists