linux-kernel - [PATCH] video: don't use flush_scheduled_work() in fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110615160025.GB8141@htj.dyndns.org>
Date:	Wed, 15 Jun 2011 18:00:25 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Jaya Kumar <jayakumar.lkml@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] video: don't use flush_scheduled_work() in fb_defio

flush_scheduled_work() in on the way out.  fb_deferred_io_cleanup()
can simply sync-cancel info->deferred_work instead of cancel +
flush_scheduled_work().  Drop flush_scheduled_work() usage.

Signed-off-by: Tejun Heo <tj@...nel.org>
Cc: Jaya Kumar <jayakumar.lkml@...il.com>
---
Compile tested.  I'm planning on marking flush_scheduled_work()
deprecated in linux-next so it would be great if this can show up
there soonish.  Thank you.

Resending because @intworks.biz bounced.  Please update MAINTAINERS
with new email address.

 drivers/video/fb_defio.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: work/drivers/video/fb_defio.c
===================================================================
--- work.orig/drivers/video/fb_defio.c
+++ work/drivers/video/fb_defio.c
@@ -216,8 +216,7 @@ void fb_deferred_io_cleanup(struct fb_in
 	int i;
 
 	BUG_ON(!fbdefio);
-	cancel_delayed_work(&info->deferred_work);
-	flush_scheduled_work();
+	cancel_delayed_work_sync(&info->deferred_work);
 
 	/* clear out the mapping that we setup */
 	for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/