linux-kernel - Re: [PATCH] EFIFB: Fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110615023718.GK17891@linux-sh.org>
Date:	Wed, 15 Jun 2011 11:37:19 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	David Howells <dhowells@...hat.com>
Cc:	pjones@...hat.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] EFIFB: Fix error handling

On Wed, Jun 15, 2011 at 01:38:17AM +0100, David Howells wrote:
> Fix the error handling in the EFIFB driver if platform_driver_probe() fails.
> In that case, the code will pass the driver struct to the _device_
> unregistration function.  It presumably should pass a pointer to the device
> struct instead.
> 
> The compiler gives the following warning to indicate this:
> 
> drivers/video/efifb.c: In function 'efifb_init':
> drivers/video/efifb.c:544:3: warning: passing argument 1 of 'platform_device_unregister' from incompatible pointer type
> include/linux/platform_device.h:40:13: note: expected 'struct platform_device *' but argument is of type 'struct platform_driver *'
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Peter Jones <pjones@...hat.com>
> cc: linux-fbdev@...r.kernel.org
> cc: stable@...nel.org

Thanks, I've already queued a fix for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/