linux-kernel - Re: [PATCH] ACPI, APEI, Add APEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201106161100.55165.rjw@sisk.pl>
Date:	Thu, 16 Jun 2011 11:00:54 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Huang Ying <ying.huang@...el.com>, Len Brown <lenb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] ACPI, APEI, Add APEI _OSC support

On Thursday, June 16, 2011, Matthew Garrett wrote:
> On Thu, Jun 16, 2011 at 08:40:11AM +0800, Huang Ying wrote:
> > On 06/15/2011 08:17 PM, Matthew Garrett wrote:
> > >> You means the "APEI Support" bit for standard UUID?  Do you know which
> > >> machine uses this bit?  I can write the code, but I have no machine to
> > >> test it.
> > > 
> > > I have access to a Dell system that uses this.
> > 
> > Great! Can you help us to test the code?
> 
> Yup, no problem.
> 
> > > Urgh. One machine I've looked at enables APEI if the WHEA _OSC call is 
> > > made, and then clears a flag if any other _OSC call is made. In that 
> > > specific case it doesn't seem to matter (the flag never actually gets 
> > > checked in any of the other codepaths), but it seems that the intention 
> > > is for the generic call to be made and the WHEA one to be made after 
> > > that.
> > 
> > Yes.  The WHEA call should be made after the generic one.  Another
> > situation is as follow:
> > 
> > - Generic _OSC call without "APEI Support" bit is called (in
> > acpi_bus_osc_support).
> > 
> > - After some time, when we think it is good to turn on firmware first
> > mode fully, usually after we checking HEST and initializing
> > corresponding module, we make generic _OSC call with "APEI Support" bit
> > to turn on firmware first mode fully in standard way.
> > 
> > Is it a good idea to make generic _OSC call twice, one without "APEI
> > Support" bit, the other with "APEI Support" bit?
> 
> I think we probably need to make the HEST decision early, and use that 
> to decide how to make the generic call. Our experience has been that 
> many firmware vendors only expect _OSC to be called once with any given 
> UUID - multiple calls can result in unexpected behaviour.

Not really, as long as the "query enable" bit is set.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/