linux-kernel - Re: [PATCH] FRV: Hook up gpiolib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110616102209.GC5262@opensource.wolfsonmicro.com>
Date:	Thu, 16 Jun 2011 11:22:10 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-kernel@...r.kernel.org, grant@...retlab.ca
Subject: Re: [PATCH] FRV: Hook up gpiolib support

On Thu, Jun 16, 2011 at 07:36:31AM +0100, David Howells wrote:
> Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> > Could you be more specific about the issue you see here?

> I was specific:

> 	Take gpio_get_value() for instance, it requires __gpio_get_value() -
> 	which is defined by the asm-generic header - but is used by
> 	gpio_get_value_cansleep() in the asm-generic header.

> gpio_get_value() is defined in the arch header.

And to repeat what I said: the generic header prototypes everything it
needs before it uses it so there should be no problem here, it's not
been a problem on the other architectures using this code verbatim.
Please be more specific.

If there's some problem none of the tools notice or some FRV specific
issue you're going to have to tell us what it is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/