lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2011 15:34:29 +0400 From: Sergei Shtylyov <sshtylyov@...sta.com> To: Denis Kuzmenko <list@...onet.org.ua> CC: Sergei Shtylyov <sshtylyov@...sta.com>, Ben Dooks <ben-linux@...ff.org>, Russell King <linux@....linux.org.uk>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support Hello. On 15-06-2011 0:31, Denis Kuzmenko wrote: >> Need an empty line here... >> Your patch is line wrapped. Seems easy to fix though... > Thank you. Is the patch below okay? Not yet. :-) > From: Denis Kuzmenko <dart@...onet.org.ua> > LCD-W35i support for Mini2440 development board Your signoff needs to be here. Sorry -- didn't notice the first time. > --- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-03 > 03:34:20.000000000 +0300 > +++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-13 > 23:37:38.785984118 +0300 > @@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440 > .lcdcon5 = (S3C2410_LCDCON5_FRM565 | > S3C2410_LCDCON5_HWSWP), > }, > + /* LCD-W35i 3.5" display (LQ035Q1DG06)*/ > + [3] = { > + _LCD_DECLARE( > + 7, /* clock */ > + 320, 68, 66, 4, /* xres, margin_right, margin_left, hsync */ > + 240, 4, 4, 9, /* yres, margin_top, margin_bottom, vsync */ > + 60), /* refresh rate */ > + .lcdcon5 = (S3C2410_LCDCON5_FRM565 | > + S3C2410_LCDCON5_INVVDEN | > + S3C2410_LCDCON5_INVVFRAME | > + S3C2410_LCDCON5_INVVLINE | > + S3C2410_LCDCON5_INVVCLK | > + S3C2410_LCDCON5_HWSWP), > + }, > }; The patch has all tabs converted to spaces. Didn't notice it the first time as well... :-/ WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists