linux-kernel - Re: [PATCH] OMAP4: GPIO: Fix missing interrupts during device wakeup due to IOPAD.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110616144146.GC2806@ponder.secretlab.ca>
Date:	Thu, 16 Jun 2011 08:41:46 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Ambresh K <ambresh@...com>
Cc:	linux kernel <linux-kernel@...r.kernel.org>,
	Philippe Mazet <p-mazet@...com>, Kevin Hilman <khilman@...com>,
	Colin Cross <ccross@...roid.com>,
	linux omap <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] OMAP4: GPIO: Fix missing interrupts during device wakeup
 due to IOPAD.

On Wed, Jun 15, 2011 at 01:40:45PM -0700, Ambresh K wrote:
> From: Ambresh K <ambresh@...com>
> 
> If gpio pins from bank[2-5] are marked as wakeup enable and if the wake is
> through gpio IO pad wakeup, then that wakeup gpio interrupt is lost.
> 
> In the current implementation, GPIO driver stores the context of DATAIN of
> all the gpio in the bank. During GPIO resuming, it checks DATAIN with wakeup
> enabled pins of gpio bank. If there is status change, then manually toggle
> GPIO_LEVELDETECT to generate pseudo interrupt.
> 
> Reported-by: Philippe Mazet <p-mazet@...com>
> Tested-by: Philippe Mazet <p-mazet@...com>
> Signed-off-by: Ambresh K <ambresh@...com>

Applied, thanks.

g.

> ---
>  drivers/gpio/gpio-omap.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 6c51191..eaf3d78 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -477,8 +477,9 @@ static inline void set_24xx_gpio_triggering(struct gpio_bank *bank, int gpio,
>  					+ OMAP24XX_GPIO_CLEARWKUENA);
>  		}
>  	}
> -	/* This part needs to be executed always for OMAP34xx */
> -	if (cpu_is_omap34xx() || (bank->non_wakeup_gpios & gpio_bit)) {
> +	/* This part needs to be executed always for OMAP{34xx, 44xx} */
> +	if (cpu_is_omap34xx() || cpu_is_omap44xx() ||
> +			(bank->non_wakeup_gpios & gpio_bit)) {
>  		/*
>  		 * Log the edge gpio and manually trigger the IRQ
>  		 * after resume if the input level changes
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/