linux-kernel - Re: [PATCH 11/11] usb/class: use printk_ratelimited() instead of printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2011 09:36:10 -0600
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Manuel Zerpies <manuel.f.zerpies@...stud.uni-erlangen.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	christian.dietrich@...ormatik.uni-erlangen.de
Subject: Re: [PATCH 11/11] usb/class: use printk_ratelimited() instead of
 printk_ratelimit()

On Thu, 16 Jun 2011 14:15:54 +0200
Manuel Zerpies <manuel.f.zerpies@...stud.uni-erlangen.de> wrote:

> +++ b/drivers/usb/class/usblp.c
> @@ -348,8 +349,7 @@ static int usblp_check_status(struct usblp *usblp, int err)
>  	mutex_lock(&usblp->mut);
>  	if ((error = usblp_read_status(usblp, usblp->statusbuf)) < 0) {
>  		mutex_unlock(&usblp->mut);
> -		if (printk_ratelimit())
> -			printk(KERN_ERR
> +		printk_ratelimited(KERN_ERR
>  				"usblp%d: error %d reading printer status\n",

I wish you went a step further and placed the state into usblp,
but it works for now, ACK. I should've done it myself, really.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/