| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.44L0.1106161308310.2204-100000@iolanthe.rowland.org> Date: Thu, 16 Jun 2011 13:09:58 -0400 (EDT) From: Alan Stern <stern@...land.harvard.edu> To: Alexander Holler <holler@...oftware.de> cc: gregkh@...e.de, Rabin Vincent <rabin@....in>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, Arnd Bergmann <arnd@...db.de> Subject: Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removing the packed attribute On Thu, 16 Jun 2011, Alexander Holler wrote: > In commit 139540170d9d9b7ead3caaf540f161756b356d56 the attribute > packed is removed from the structs which are used to access the EHCI-registers. > > This is done to circumvent a problem with gcc 4.6, which might access members of > packed structs on a byte by byte basis. But using packed, aligned(4) fixes that > too and is imho the better solution. Otherwise (without packed) the compiler would be free > to choose whatever alignment he thinks fits best, which might be e.g. 8-byte on 64-bit machines. Is that really true? I thought the compiler was not allowed to insert padding if the natural alignment of the data types didn't require any. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists