linux-kernel - Re: [PATCH] um: Clean up vm-flags.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110616122738.697a7c12.randy.dunlap@oracle.com>
Date:	Thu, 16 Jun 2011 12:27:38 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Richard Weinberger <richard@....at>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net,
	randy.dunlap@...cle.com, mhocko@...e.cz,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] um: Clean up vm-flags.h

On Thu, 16 Jun 2011 21:01:07 +0200 Richard Weinberger wrote:

> There is no need to define VM_{STACK,DATA}_DEFAULT_FLAGS as
> variable.
> It's also useless to test for TIF_IA32 as 64bit UML has no
> IA32 emulation.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> CC: randy.dunlap@...cle.com

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> CC: mhocko@...e.cz
> CC: torvalds@...ux-foundation.org
> ---
>  arch/um/sys-x86_64/Makefile                 |    2 +-
>  arch/um/sys-x86_64/mem.c                    |   16 ----------------
>  arch/um/sys-x86_64/shared/sysdep/vm-flags.h |   26 ++++----------------------
>  3 files changed, 5 insertions(+), 39 deletions(-)
>  delete mode 100644 arch/um/sys-x86_64/mem.c
> 
> diff --git a/arch/um/sys-x86_64/Makefile b/arch/um/sys-x86_64/Makefile
> index c1ea9eb..63fe0d2 100644
> --- a/arch/um/sys-x86_64/Makefile
> +++ b/arch/um/sys-x86_64/Makefile
> @@ -4,7 +4,7 @@
>  # Licensed under the GPL
>  #
>  
> -obj-y = bug.o bugs.o delay.o fault.o ldt.o mem.o ptrace.o ptrace_user.o \
> +obj-y = bug.o bugs.o delay.o fault.o ldt.o ptrace.o ptrace_user.o \
>  	setjmp.o signal.o stub.o stub_segv.o syscalls.o syscall_table.o \
>  	sysrq.o ksyms.o tls.o
>  
> diff --git a/arch/um/sys-x86_64/mem.c b/arch/um/sys-x86_64/mem.c
> deleted file mode 100644
> index 3f8df8a..0000000
> --- a/arch/um/sys-x86_64/mem.c
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -/*
> - * Copyright 2003 PathScale, Inc.
> - *
> - * Licensed under the GPL
> - */
> -
> -#include "linux/mm.h"
> -#include "asm/page.h"
> -#include "asm/mman.h"
> -
> -unsigned long vm_stack_flags = __VM_STACK_FLAGS;
> -unsigned long vm_stack_flags32 = __VM_STACK_FLAGS;
> -unsigned long vm_data_default_flags = __VM_DATA_DEFAULT_FLAGS;
> -unsigned long vm_data_default_flags32 = __VM_DATA_DEFAULT_FLAGS;
> -unsigned long vm_force_exec32 = PROT_EXEC;
> -
> diff --git a/arch/um/sys-x86_64/shared/sysdep/vm-flags.h b/arch/um/sys-x86_64/shared/sysdep/vm-flags.h
> index 3213edf..3978e55 100644
> --- a/arch/um/sys-x86_64/shared/sysdep/vm-flags.h
> +++ b/arch/um/sys-x86_64/shared/sysdep/vm-flags.h
> @@ -7,27 +7,9 @@
>  #ifndef __VM_FLAGS_X86_64_H
>  #define __VM_FLAGS_X86_64_H
>  
> -#define __VM_DATA_DEFAULT_FLAGS	(VM_READ | VM_WRITE | VM_EXEC | \
> -				 VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
> -#define __VM_STACK_FLAGS 	(VM_GROWSDOWN | VM_READ | VM_WRITE | \
> -				 VM_EXEC | VM_MAYREAD | VM_MAYWRITE | \
> -				 VM_MAYEXEC)
> -
> -extern unsigned long vm_stack_flags, vm_stack_flags32;
> -extern unsigned long vm_data_default_flags, vm_data_default_flags32;
> -extern unsigned long vm_force_exec32;
> -
> -#ifdef TIF_IA32
> -#define VM_DATA_DEFAULT_FLAGS \
> -	(test_thread_flag(TIF_IA32) ? vm_data_default_flags32 : \
> -	  vm_data_default_flags)
> -
> -#define VM_STACK_DEFAULT_FLAGS \
> -	(test_thread_flag(TIF_IA32) ? vm_stack_flags32 : vm_stack_flags)
> -#endif
> -
> -#define VM_DATA_DEFAULT_FLAGS vm_data_default_flags
> -
> -#define VM_STACK_DEFAULT_FLAGS vm_stack_flags
> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
> +	VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
> +#define VM_STACK_DEFAULT_FLAGS (VM_GROWSDOWN | VM_READ | VM_WRITE | \
> +	VM_EXEC | VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>  
>  #endif
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/