linux-kernel - Re: m68k: Convert to genirq (WIP)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2011 21:45:11 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Andreas Schwab <schwab@...ux-m68k.org>,
	Michael Schmitz <schmitzmic@...glemail.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	"Linux/m68k" <linux-m68k@...ts.linux-m68k.org>
Subject: Re: m68k: Convert to genirq (WIP)

On Sat, May 28, 2011 at 20:32, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> | ------------[ cut here ]------------
> | WARNING: at linux/kernel/irq/handle.c:130 handle_irq_event_percpu+0xe6/0x148()
> | irq 3 handler nfeth_interrupt+0x0/0x126 enabled interrupts
> | Modules linked in:
> | Call Trace: [<00027670>] warn_slowpath_common+0x3e/0x64
> |  [<0002767e>] warn_slowpath_common+0x4c/0x64
> |  [<0002770c>] warn_slowpath_fmt+0x2a/0x32
> |  [<0004d01a>] handle_irq_event_percpu+0xe6/0x148
> |  [<0004d01a>] handle_irq_event_percpu+0xe6/0x148
> |  [<00009d64>] nfeth_interrupt+0x0/0x126
> |  [<00027dc8>] printk+0x0/0x1a
> |  [<0004d09c>] handle_irq_event+0x20/0x2c
> |  [<0004ecce>] handle_level_irq+0x50/0x9c
> |  [<002496b8>] schedule+0x0/0x31e
> |  [<00006782>] do_IRQ+0x2e/0x44
> |  [<00027dc8>] printk+0x0/0x1a
> |  [<00003eb4>] __m68k_handle_int+0xe/0x12
> |  [<000026e2>] auto_irqhandler_fixup+0x4/0x6
> |  [<00027dc8>] printk+0x0/0x1a
> |  [<00002c46>] default_idle+0x0/0xe
> |  [<00002b0c>] cpu_idle+0x16/0x22
> |  [<00002b18>] kernel_thread+0x0/0x4e
> |  [<00248610>] rest_init+0x5c/0x62
> |  [<0031a220>] start_kernel+0x3a4/0x3b0
> |  [<000106aa>] ssincos+0x27e/0x2ac
> |  [<000106aa>] ssincos+0x27e/0x2ac
> |  [<0031931e>] _sinittext+0x31e/0x9c0
> |
> | ---[ end trace 139ce121c98e96cb ]---

This is the WARN_ONCE(!irqs_disabled()) check.

static inline bool arch_irqs_disabled_flags(unsigned long flags)
{
        return (flags & ~ALLOWINT) != 0;
}

with flags = 0x2300. Due to the "special" value of ALLOWINT on Atari:

#if defined(MACH_ATARI_ONLY)
        /* block out HSYNC on the atari */
#define ALLOWINT        (~0x400)
#define MAX_NOINT_IPL   3
#else
        /* portable version */
#define ALLOWINT        (~0x700)
#define MAX_NOINT_IPL   0
#endif /* machine compilation types */

the test fails.

Would it harm to always use the "portable" version?
That one is used on multi-platform kernels anyway?
Or would it cause too many HBLANK interrupts?

BTW, MAX_NOINT_IPL is no longer used.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/