linux-kernel - Re: [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87hb7oi45u.fsf@eliezer.anholt.net>
Date:	Fri, 17 Jun 2011 13:39:09 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Daniel J Blueman <daniel.blueman@...il.com>
Cc:	Dave Airlie <airlied@...hat.com>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Ben Widawsky <ben@...dawsk.net>,
	Kenneth Graunke <kenneth@...tecape.org>,
	Yi Sun <yi.sun@...el.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Mengmeng Meng <mengmeng.meng@...el.com>,
	Robert Hooker <sarvatt@...ntu.com>
Subject: Re: [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling

On Sat, 18 Jun 2011 02:20:08 +0800, Daniel J Blueman <daniel.blueman@...il.com> wrote:
> On 18 June 2011 01:44, Eric Anholt <eric@...olt.net> wrote:
> > On Sat, 18 Jun 2011 00:42:00 +0800, Daniel J Blueman <daniel.blueman@...il.com> wrote:
> >> Workaround Sandy Bridge GPU stalls by allowing the blitter command streamer
> >> to write interrupt state to the Hardware Status Page when a MI_USER_INTERRUPT
> >> command is decoded.
> >>
> >> v1->v2: Moved to prior interrupt handler installation and RMW flags as per
> >> feedback.
> >
> > We shouldn't be RMWing.  We're the driver, we're supposed to know what
> > we want.  I'm backing that bit out, will do another round of testing,
> > and send it off.
> 
> I still prefer directly setting the mask due to my earlier reasons.
> Unmasking in the IRQ preinstall tests good here, so I'll send a v3
> patch in the morning.

Already tested and sent v3 out to lkml.

Content of type "application/pgp-signature" skipped