linux-kernel - Re: [Patch] hugetlb: remove user_shm_lock() check from hugetlb_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1106181630480.3431@chino.kir.corp.google.com>
Date:	Sat, 18 Jun 2011 16:34:16 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Ravikiran Thirumalai <kiran@...lex86.org>,
	William Irwin <wli@...omorphy.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>
Subject: Re: [Patch] hugetlb: remove user_shm_lock() check from
 hugetlb_file_setup()

On Sat, 18 Jun 2011, Américo Wang wrote:

> 
> This is a revert of
> 
> commit 2584e517320bd48dc8d20e38a2621a2dbe58fade
> Author: Ravikiran G Thirumalai <kiran@...lex86.org>
> Date:   Tue Mar 31 15:21:26 2009 -0700
> 
>     mm: reintroduce and deprecate rlimit based access for SHM_HUGETLB
> 
> 
> because it is deprecated and scheduled to be removed.
> 

I know this is scheduled for removal and it is quite past due, but I think 
we need to do some due diligence before just yanking the whole thing out.  
A printk_once() about some mysterious application using SHM_HUGETLB 
doesn't seem very helpful in migrating users to start using 
/proc/sys/vm/hugetlb_shm_group, and suddenly returning -EPERM when 
attempting it doesn't seem very responsible, despite what 
Documentation/feature-removal-schedule.txt may say.

For context, we just ran into this internally where this warning at one 
point appeared to be WARN_ON_ONCE().  That seems more attention grabbing 
because it at least allows users to start understanding what the issue is 
and who needs to be fixed.