linux-kernel - Re: 37573e8c (cgroup fix) causing implicit declaration of function 'node_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110619183955.GH2031@gallifrey>
Date:	Sun, 19 Jun 2011 19:39:55 +0100
From:	"Dr. David Alan Gilbert" <dave@...blig.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	linux-kernel@...r.kernel.org, kamezawa.hiroyu@...fujitsu.com
Subject: Re: 37573e8c (cgroup fix) causing implicit declaration of function
	'node_start_pfn'

* Randy Dunlap (rdunlap@...otime.net) wrote:
> On Sun, 19 Jun 2011 16:12:14 +0100 Dr. David Alan Gilbert wrote:
> 
> > Hi,
> >   The current git head is failing to build for me with:
> > 
> > mm/page_cgroup.c: In function 'page_cgroup_init':
> > mm/page_cgroup.c:308:3: error: implicit declaration of function 'node_start_pfn'
> > mm/page_cgroup.c:309:3: error: implicit declaration of function 'node_end_pfn'
> > 
> > this is for a very basic 32bit x86 build, and it looks like
> > include/asm/mmzone_32.h only defines node_start_pfn and node_end_pfn on
> > CONFIG_DISCONTIGMEM - which I have off.
> > 
> > The use of node_start_pfn seems to be from 
> > 
> >   commit 37573e8c718277103f61f03741bdc5606d31b07e
> >   Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> >   Date:   Wed Jun 15 15:08:42 2011 -0700
> > 
> >      memcg: fix init_page_cgroup nid with sparsemem
> 
> Please see if http://marc.info/?l=linux-kernel&m=130827204306775&w=2
> fixes it for you.

Yes it does (build tested only); thank you for the pointer.

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\ gro.gilbert @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/