linux-kernel - Re: [PATCH 10/19] OpenRISC: System calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2k4chfrwf.fsf@firstfloor.org>
Date:	Sun, 19 Jun 2011 14:11:28 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Jonas Bonn <jonas@...thpole.se>
Cc:	richard -rw- weinberger <richard.weinberger@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/19] OpenRISC: System calls

Jonas Bonn <jonas@...thpole.se> writes:

> On Sun, 2011-06-19 at 17:09 +0200, richard -rw- weinberger wrote:
>> On Sun, Jun 19, 2011 at 1:43 PM, Jonas Bonn <jonas@...thpole.se> wrote:
>> > +asmlinkage int _sys_vfork(struct pt_regs *regs)
>> > +{
>> > +       /* This doesn't seem to work */
>> > +//        return do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, regs->sp, regs, 0, NULL, NULL);
>> 
>> Just being curious, why does that not work?
>
> Something about the CLONE_VM flag is breaking things... not sure what,

When "breaking" is a kernel oops or similar then you have a security
hole because CLONE_VM can be specified directly by user space in
clone()

So most likely you need to fix that anyways.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/