linux-kernel - Re: Regression caused by "Bluetooth: Map sec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yun8vsynkiy.fsf@aiko.keithp.com>
Date:	Sun, 19 Jun 2011 13:11:17 +0200
From:	Keith Packard <keithp@...thp.com>
To:	Luiz Augusto von Dentz <luiz.dentz@...il.com>,
	Waldemar.Rymarkiewicz@...to.com, padovan@...fusion.mobi,
	marcel@...tmann.org, linux-bluetooth@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: Regression caused by "Bluetooth: Map sec_level to link key requirements"

On Fri, 10 Jun 2011 14:58:50 +0900, Luiz Augusto von Dentz <luiz.dentz@...il.com> wrote:

> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 2f5ae53..b309f84 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -673,8 +673,8 @@ auth:
>         if (test_and_set_bit(HCI_CONN_ENCRYPT_PEND, &conn->pend))
>                 return 0;
> 
> -       hci_conn_auth(conn, sec_level, auth_type);
> -       return 0;
> +       if (!(hci_conn_auth(conn, sec_level, auth_type)))
> +               return 0;
> 
>  encrypt:
>         if (conn->link_mode & HCI_LM_ENCRYPT)

That makes the first connection afer boot succeed, but subsequent
connections fail in the same way.

-- 
keith.packard@...el.com

Content of type "application/pgp-signature" skipped