linux-kernel - Re: [PATCH][Trivial] S3C2410 bluetooth: Remove duplicate linux/leds.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2011 12:32:49 +0300
From:	Vitaliy Ivanov <vitalivanov@...il.com>
To:	Jesper Juhl <jj@...osbits.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Vasily Khoruzhick <anarsoul@...il.com>, trivial@...nel.org,
	linux-kernel@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH][Trivial] S3C2410 bluetooth: Remove duplicate linux/leds.h include

Jusper/Linus/All,

On Mon, Jun 20, 2011 at 11:40 AM, Jesper Juhl <jj@...osbits.net> wrote:
> Remove the duplicate inclusion of linux/leds.h from
> arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d.
>
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  h1940-bluetooth.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c2410/h1940-bluetooth.c b/arch/arm/mach-s3c2410/h1940-bluetooth.c
> index 2c126bb..a5eeb62 100644
> --- a/arch/arm/mach-s3c2410/h1940-bluetooth.c
> +++ b/arch/arm/mach-s3c2410/h1940-bluetooth.c
> @@ -18,7 +18,6 @@
>  #include <linux/leds.h>
>  #include <linux/gpio.h>
>  #include <linux/rfkill.h>
> -#include <linux/leds.h>
>
>  #include <mach/regs-gpio.h>
>  #include <mach/hardware.h>
>
> --

Some time ago I already sent a patch to handle all the headers
duplication corrections. Please check this:

https://lkml.org/lkml/2011/6/16/301

It should handle all the cases you described at:

https://lkml.org/lkml/2011/6/20/72
https://lkml.org/lkml/2011/6/20/78
https://lkml.org/lkml/2011/6/20/75

I didn't receive any comments and still can see that it's not in
mainline Linus' tree.


Thanks,
Vitaliy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/