linux-kernel - Re: [PATCH 01/12] vmscan: add shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110620005321.GM561@dastard>
Date:	Mon, 20 Jun 2011 10:53:21 +1000
From:	Dave Chinner <david@...morbit.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, xfs@....sgi.com
Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints

On Mon, Jun 20, 2011 at 09:44:33AM +0900, KOSAKI Motohiro wrote:
> (2011/06/02 16:00), Dave Chinner wrote:
> > From: Dave Chinner <dchinner@...hat.com>
> > 
> > Іt is impossible to understand what the shrinkers are actually doing
> > without instrumenting the code, so add a some tracepoints to allow
> > insight to be gained.
> > 
> > Signed-off-by: Dave Chinner <dchinner@...hat.com>
> > ---
> >  include/trace/events/vmscan.h |   67 +++++++++++++++++++++++++++++++++++++++++
> >  mm/vmscan.c                   |    6 +++-
> >  2 files changed, 72 insertions(+), 1 deletions(-)
> 
> This look good to me. I have two minor request. 1) please change patch order,
> move this patch after shrinker changes. iow, now both this and [2/12] have
> tracepoint change. I don't like it.

No big deal - I'll just fold the second change (how shrinker->nr is
passed into the tracepoint) into the first. Tracepoints should be
first in the series, anyway, otherwise there is no way to validate
the before/after effect of the bug fixes....

> 2) please avoid cryptic abbreviated variable
> names. Instead, please just use the same variable name with
> vmscan.c source code.

So replace cryptic abbreviated names with slightly different
cryptic abbreviated names? ;)

Sure, I can do that...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/