linux-kernel - Re: [PATCH] mfd: Implement tps65910 IRQ cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2011 20:55:00 +0200
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: Implement tps65910 IRQ cleanup

On 06/20/2011 12:47 PM, Mark Brown wrote:
> The tps65910_irq_exit() cleanup function was generating a warning from
> sparse due to the lack of a prototype. This wasn't causing GCC warnings
> as the driver wasn't cleaning up its IRQs on exit at all so there was no
> use of an unprototyped function.
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/tps65910.c       |    1 +
>  include/linux/mfd/tps65910.h |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 2229e66..837f0e6 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -187,6 +187,7 @@ static int tps65910_i2c_remove(struct i2c_client *i2c)
>  	struct tps65910 *tps65910 = i2c_get_clientdata(i2c);
>  
>  	mfd_remove_devices(tps65910->dev);
> +	tps65910_irq_exit(tps65910);
>  	kfree(tps65910);
>  
>  	return 0;
> diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
> index 8bb85b9..efcdb29 100644
> --- a/include/linux/mfd/tps65910.h
> +++ b/include/linux/mfd/tps65910.h
> @@ -791,6 +791,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask);
>  void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base);
>  int tps65910_irq_init(struct tps65910 *tps65910, int irq,
>  		struct tps65910_platform_data *pdata);
> +int tps65910_irq_exit(struct tps65910 *tps65910);
>  
>  static inline int tps65910_chip_id(struct tps65910 *tps65910)
>  {
Acked-by: Graeme Gregory <gg@...mlogic.co.uk>

Thanks for that cleanup.

Graeme
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/