linux-kernel - Re: [PATCH] linux/uaccess.h needs to #include linux/kernel.h for might

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110620164241.ac6b5d2a.akpm@linux-foundation.org>
Date:	Mon, 20 Jun 2011 16:42:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...ux-foundation.org, linux-am33-list@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/uaccess.h needs to #include linux/kernel.h for
 might_sleep()

On Wed, 15 Jun 2011 01:22:10 +0100
David Howells <dhowells@...hat.com> wrote:

> linux/uaccess.h needs to #include linux/kernel.h to get might_sleep() otherwise
> it fails to build on MN10300 allyesconfig.  This fails in a few places with
> messages like the following:

uaccess.h doesn't textually refer to might_sleep().

> In file included from security/keys/trusted.c:14:
> include/linux/uaccess.h: In function '__copy_from_user_nocache':
> include/linux/uaccess.h:52: error: implicit declaration of function 'might_sleep'

This happened because of arch/mn10300/include/asm/uaccess.h's

#define __copy_from_user(to, from, n)			\
({							\
	might_sleep();					\
	__copy_from_user_inatomic((to), (from), (n));	\
})

>  include/linux/uaccess.h |    1 +

So I'd suggest that patching the arch header file is the appropriate fix.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/