linux-kernel - Re: [PATCH] s3c2410_udc: fix custom UDC command handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2011 10:25:51 +0200
From:	Viliam Mateicka <viliam.mateicka@...il.com>
To:	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, viliam.mateicka@...il.com
Subject: Re: [PATCH] s3c2410_udc: fix custom UDC command handling

So, will somebody at least react/reply (or just fix) ?

Vilo

On Thu, Jun 16, 2011 at 10:04 AM, Viliam Mateicka
<viliam.mateicka@...il.com> wrote:
> There is a bug in Samsung's UDC driver, which is completely disabling
> the USB device when a custom UDC command is used.
> Following patch seems to get the right behavior (e.g. enabling pull-up
> instead of disabling then Vcc is applied). Also I'm not in mailing
> list so please CC me.
>
> Greetingz,
> Vilo
>
> Signed-off-by: Viliam Mateicka <viliam.mateicka@...il.com>
>
> --- drivers/usb/gadget/s3c2410_udc.c.orig       2011-05-19
> 06:06:34.000000000 +0200
> +++ drivers/usb/gadget/s3c2410_udc.c    2011-06-16 08:57:19.000000000 +0200
> @@ -1566,7 +1566,7 @@ static void s3c2410_udc_command(enum s3c
>                 return;
>         if (udc_info->udc_command) {
> -               udc_info->udc_command(S3C2410_UDC_P_DISABLE);
> +               udc_info->udc_command(cmd);
>         } else if (gpio_is_valid(udc_info->pullup_pin)) {
>                 int value;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/