linux-kernel - Re: [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110621002322.GE1905@opensource.wolfsonmicro.com>
Date:	Tue, 21 Jun 2011 01:23:39 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Taylor Hutt <thutt@...omium.org>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Peter Hsiang <Peter.Hsiang@...im-ic.com>,
	Olof Johansson <olofj@...omium.org>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision.

On Mon, Jun 20, 2011 at 11:54:32AM -0700, Taylor Hutt wrote:
> The base hardware revision of the Maxim 98095 part is 0x40; the code
> which outputs the revision of the hardware has been updated to
> properly use uppercase alphabetic values for the revision numbers.

Are you sure that this is true for all devices that might be supported
by the driver (I'm guessing there may be other variants)?  There's often
a drift between silicon and package revisions which gets papered over by
datasheets and ignored by drivers.

> Also, the use of a constant for the length 'max98095_dai' has been
> replaced with ARRAY_SIZE().

Don't include a series of random unrelated changes in a single patch,
split them up into separate patches.  This makes review much easier if
nothing else.  There's no overlap at all between this change and the one
above.  The change is sensible.

>  	ret = snd_soc_read(codec, M98095_0FF_REV_ID);
>  	if (ret < 0) {
> -		dev_err(codec->dev, "Failed to read device revision: %d\n",
> +		dev_err(codec->dev, "Failure reading hardware revision: %d\n",
>  			ret);

You've also got this again unrelated change which isn't mentioned in the
changelog at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/