linux-kernel - Re: [PATCH 14/19] OpenRISC: Module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2011 16:03:36 -0400
From:	Valdis.Kletnieks@...edu
To:	Jonas Bonn <jonas@...thpole.se>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/19] OpenRISC: Module support

On Sun, 19 Jun 2011 13:43:40 +0200, Jonas Bonn said:

Arnd already did a number of comments - two things I didn't see him note:

>  arch/openrisc/kernel/module.c |  126 +++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 126 insertions(+), 0 deletions(-)
>  create mode 100644 arch/openrisc/kernel/module.c
> 
> diff --git a/arch/openrisc/kernel/module.c b/arch/openrisc/kernel/module.c
> new file mode 100644
> index 0000000..952b129
> --- /dev/null
> +++ b/arch/openrisc/kernel/module.c
> @@ -0,0 +1,126 @@
> +/*
> + * OpenRISC module.c

Lose the filenames in the headers - you do this in multiple files.

Also, do you even *need* a module.c? There isn't much in here, will the main
kernel/module.c do the work needed?  Or did you end up with one because the
arch you cloned had one?

Content of type "application/pgp-signature" skipped