linux-kernel - Re: [PATCH] svcauth_unix.c: quiet sparse noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110621224430.GC28047@fieldses.org>
Date:	Tue, 21 Jun 2011 18:44:30 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, linux-nfs@...r.kernel.org,
	Trond.Myklebust@...app.com, neilb@...e.de, davem@...emloft.net
Subject: Re: [PATCH] svcauth_unix.c: quiet sparse noise

On Mon, Jun 20, 2011 at 06:19:12PM -0700, H Hartley Sweeten wrote:
> Like svcauth_unix, the symbol svcauth_null is used external from this
> file. Declare it as extern to quiet the following sparse noise:
> 
> warning: symbol 'svcauth_null' was not declared. Should it be static?

Also applying for 3.1.--b.

> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Trond Myklebust <Trond.Myklebust@...app.com>
> Cc: "J. Bruce Fields" <bfields@...ldses.org>
> Cc: Neil Brown <neilb@...e.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> 
> ---
> 
> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
> index c8e1021..62e49e2 100644
> --- a/net/sunrpc/svcauth_unix.c
> +++ b/net/sunrpc/svcauth_unix.c
> @@ -36,6 +36,7 @@ struct unix_domain {
>  	/* other stuff later */
>  };
>  
> +extern struct auth_ops svcauth_null;
>  extern struct auth_ops svcauth_unix;
>  
>  static void svcauth_unix_domain_release(struct auth_domain *dom)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/