linux-kernel - Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTi=udZv3g-jB+FBWyaXqhQie3B2EaA@mail.gmail.com>
Date:	Wed, 22 Jun 2011 11:38:41 +0200
From:	Per Forlin <per.forlin@...aro.org>
To:	Nickolay Nickolaev <nicknickolaev@...il.com>
Cc:	linaro-dev@...ts.linaro.org,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, Venkatraman S <svenkatr@...com>
Subject: Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req

On 22 June 2011 11:31, Per Forlin <per.forlin@...aro.org> wrote:
> On 22 June 2011 10:51, Nickolay Nickolaev <nicknickolaev@...il.com> wrote:
>> Hello,
>>
>> this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is
>> not defined.
>>
> I don't see this issue when I compile the kernel for a Pandaboard
> without CONFIG_DMA_ENGINE being set. Could you please clarify or show
> me your build log?
> I don't see how host->next_data.cookie is connected to DMA_ENGINE.
>
I think you are referring to the mmci-patch. I'll fix the issue in mmci.

>> On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin <per.forlin@...aro.org> wrote:
>>>
>>> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct
>>> platform_device *pdev)
>>>        host->mapbase   = res->start;
>>>        host->base      = ioremap(host->mapbase, SZ_4K);
>>>        host->power_mode = MMC_POWER_OFF;
>>> +       host->next_data.cookie = 1;
>>>
>>>        platform_set_drvdata(pdev, host);
>>>        INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect);
>>> --
>>> 1.7.4.1
>>>
>>>
>>
>> Maybe we can wrap it in a function as the others.
>>
>> regards,
>> Nikolay Nikolaev
>>
>
> Regards,
> Per
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/