linux-kernel - Re: [PATCH] perf tools: Don't corrupt PERF-VERSION-FILE with make debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110622095023.GB18277@elte.hu>
Date:	Wed, 22 Jun 2011 11:50:23 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Robert Richter <robert.richter@....com>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: Don't corrupt PERF-VERSION-FILE with make
 debug


* Robert Richter <robert.richter@....com> wrote:

> When running make with debug option -d the PERF-VERSION-FILE gets
> corrupted because make is noisy:
> 
>  PERF-VERSION-FILE:2: *** missing separator.  Stop.
> 
> Fixing this by not passing the make flags in the MAKEFLAGS environment
> variable to the sub-make that generates the version string.
> 
> Signed-off-by: Robert Richter <robert.richter@....com>
> ---
>  tools/perf/util/PERF-VERSION-GEN |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/PERF-VERSION-GEN b/tools/perf/util/PERF-VERSION-GEN
> index 9c5fb4d..ad73300 100755
> --- a/tools/perf/util/PERF-VERSION-GEN
> +++ b/tools/perf/util/PERF-VERSION-GEN
> @@ -23,7 +23,7 @@ if test -d ../../.git -o -f ../../.git &&
>  then
>  	VN=$(echo "$VN" | sed -e 's/-/./g');
>  else
> -	VN=$(make -sC ../.. kernelversion)
> +	VN=$(MAKEFLAGS= make -sC ../.. kernelversion)

Yeah, and this has been fixed recently, via:

  37aa9a2eb4d9: perf: clear out make flags when calling kernel make kernelver

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/