linux-kernel - Re: [PATCH 3/4] mm: improve THP printk messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2011 18:23:57 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Amerigo Wang <amwang@...hat.com>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Rik van Riel <riel@...hat.com>,
	Johannes Weiner <jweiner@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm@...ck.org
Subject: Re: [PATCH 3/4] mm: improve THP printk messages

On Tue, 21 Jun 2011, Amerigo Wang wrote:

> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 126c96b..f9e720c 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -506,7 +506,7 @@ static int __init hugepage_init(void)
>  	if (no_hugepage_init) {
>  		err = 0;
>  		transparent_hugepage_flags = 0;
> -		printk(KERN_INFO "hugepage: totally disabled\n");
> +		printk(KERN_INFO "THP: totally disabled\n");
>  		goto out;
>  	}
>  
> @@ -514,19 +514,19 @@ static int __init hugepage_init(void)
>  	err = -ENOMEM;
>  	hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj);
>  	if (unlikely(!hugepage_kobj)) {
> -		printk(KERN_ERR "hugepage: failed kobject create\n");
> +		printk(KERN_ERR "THP: failed kobject create\n");
>  		goto out;
>  	}
>  
>  	err = sysfs_create_group(hugepage_kobj, &hugepage_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "THP: failed register hugeage group\n");
>  		goto out;
>  	}
>  
>  	err = sysfs_create_group(hugepage_kobj, &khugepaged_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "THP: failed register hugeage group\n");
>  		goto out;
>  	}
>  #endif

You're changing a printk() but not fixing the typos in it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/