linux-kernel - Re: [PATCH 8/10 v2] Generic Watchdog Timer Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110622200009.GC26745@infomag.iguana.be>
Date:	Wed, 22 Jun 2011 22:00:09 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 8/10 v2] Generic Watchdog Timer Driver

Hi Arnd,

> On Saturday 18 June 2011 19:26:37 Wim Van Sebroeck wrote:
> > 
> > watchdog: WatchDog Timer Driver Core - Part 8
> >    
> > Add support for a parent device so that it can
> > be set as the parent of the misc_device.
> > 
> > Signed-off-by: Alan Cox <alan@...rguk.ukuu.org.uk>
> > Signed-off-by: Wim Van Sebroeck <wim@...ana.be>
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> How about folding this patch into the first one? It hardly adds any code 
> as much as it replaces some lines with others.

prefer to not do that for following reasons:
1) I deliberately splitted the framework in a series of patches, so that people
understand better what the differen developmentt steps have been historically
and/or logically. By splitting it, I hope that people will understand better
why the API is what it is.
2) most watchdog drivers don't do this yet. So this teaches existing device
driver writers also that this is a possible feature.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/