linux-kernel - [PATCH 0/8] kill task_detached() (Was: ptrace: kill detah tracehooks)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110622210757.GA20549@redhat.com>
Date:	Wed, 22 Jun 2011 23:07:57 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Tejun Heo <tj@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	hch@...radead.org
Subject: [PATCH 0/8] kill task_detached() (Was: ptrace: kill detah
	tracehooks)

Remove tracehook_notify_death(), and kill task_detached() logic.

IMHO, task_detached() is very strange and confusing. Sometimes it used
instead of !thread_group_leader() when the task is live. Sometimes it
is used to detect the EXIT_DEAD tasks (reparent_leader). Sometimes it
used after do_notify_parent() which sets ->exit_signal = -1 to signal
the caller it should set EXIT_DEAD.

Basically, this series does:

	- s/task_detached/thread_group_leader/ when the caller need
	  to know if it is the group_leader or not

	- s/task_detached/EXIT_DEAD/ when the caller needs to filter
	  out the EXIT_DEAD tasks

	- changes do_notify_parent() to return a boolean and converts
	  the callers from

	  	do_notify_parent(p);
	  	if (task_detached(p))
	  		// aha, do_notify_parent() changed ->exit_signal
	  		release_task(p)

	  to
		if (do_notify_parent(p))
			release_task(p)

	- kills the now unused task_detached()

	- makes task->exit_signal "const" and redefines thread_group_leader()
	  for micro-optimization.


 fs/exec.c                 |    1 +
 include/linux/sched.h     |   15 ++++-------
 include/linux/tracehook.h |   34 --------------------------
 kernel/exit.c             |   58 +++++++++++++++++++-------------------------
 kernel/ptrace.c           |   32 +++++++++++++-----------
 kernel/signal.c           |   16 ++++++------
 6 files changed, 57 insertions(+), 99 deletions(-)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/