linux-kernel - Re: [PATCH v2 1/4] mm: completely disable THP by transparent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1106212010520.8712@chino.kir.corp.google.com>
Date:	Tue, 21 Jun 2011 20:24:14 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Cong Wang <amwang@...hat.com>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Rik van Riel <riel@...hat.com>,
	Johannes Weiner <jweiner@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-doc@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/4] mm: completely disable THP by
 transparent_hugepage=0

On Wed, 22 Jun 2011, Cong Wang wrote:

> > > Introduce "transparent_hugepage=0" to totally disable THP.
> > > "transparent_hugepage=never" means setting THP to be partially
> > > disabled, we need a new way to totally disable it.
> > > 
> > 
> > Why can't you just compile it off so you never even compile
> > mm/huge_memory.c in the first place and save the space in the kernel image
> > as well?  Having the interface available to enable the feature at runtime
> > is worth the savings this patch provides, in my opinion.
> 
> https://lkml.org/lkml/2011/6/20/506
> 

If you're proposing a patch for a specific purpose, it's appropriate to 
include that in the changelog.

But now that I know what you're proposing this for, it's an easy NACK: 
transparent_hugepage=0 has no significant benefit over 
transparent_hugepage=never for kdump because the memory savings is 
negligible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/