[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20110623104525.30718cd7@endymion.delvare>
Date: Thu, 23 Jun 2011 10:45:25 +0200
From: Jean Delvare <khali@...ux-fr.org>
To: Ankur Patel <bkankur@...il.com>
Cc: Guenter Roeck <guenter.roeck@...csson.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote:
> On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@...ux-fr.org> wrote:
>
> > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> > > From: Ankur Patel <ankur.patel@...pment.in>
> > >
> > > In the tmp102.ko driver support for 12 bit data is added. Also, the
> > > sysfs names are replaced with the actual chip supported fuctionality
> > > names.
> >
> > Nack. These attribute names are standard, see
> > Documentation/hwmon/sysfs-interface. You don't get to change them.
> >
> >
> > What problem were you trying to solve? libsensors expects the attribute
> > names which are in use today.
> >
> > Agree, But using temp1_max_hyst as an attribute for presenting low level
> threshold, will it not more feasible to use temp1_low instead?.
No. This isn't a min temperature limit. Please read the TMP102
datasheet and in particular Figure 10 "Output Transfer Function
Diagrams" and the description of the AL configuration bit.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists