linux-kernel - Re: [PATCH 8/8] redefine thread_group_leader() as exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110623135638.GQ30101@htj.dyndns.org>
Date:	Thu, 23 Jun 2011 15:56:38 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	hch@...radead.org
Subject: Re: [PATCH 8/8] redefine thread_group_leader() as exit_signal >= 0

Hello,

On Wed, Jun 22, 2011 at 11:10:26PM +0200, Oleg Nesterov wrote:
> Change de_thread() to set old_leader->exit_signal = -1. This is
> good for the consistency, it is no longer the leader and all
> sub-threads have exit_signal = -1 set by copy_process(CLONE_THREAD).
> 
> And this allows us to micro-optimize thread_group_leader(), it can
> simply check exit_signal >= 0. This also makes sense because we
> should move ->group_leader from task_struct to signal_struct.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Patches 5-8 look correct to me but I frankly don't know the area
enough to assert acked-by's.  Please feel free to add reviewed-by's
tho.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/