linux-kernel - Re: [PATCH] USB: ehci: use packed, aligned(4) instead of removing the packed attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1106231022500.2033-100000@iolanthe.rowland.org>
Date:	Thu, 23 Jun 2011 10:25:30 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Alexander Holler <holler@...oftware.de>
cc:	Arnd Bergmann <arnd@...db.de>, <gregkh@...e.de>,
	Nicolas Pitre <nico@...xnic.net>, <linux-usb@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Rabin Vincent <rabin@....in>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] USB: ehci: use packed, aligned(4) instead of removing
 the packed attribute

On Thu, 23 Jun 2011, Alexander Holler wrote:

> Sorry, I never wanted to talk about the issue itself (I've already said 
> that), I just wanted to bring in some additional clarity for people 
> looking at the code.
> 
> I think if there is a packed,aligned(4) most people reading that are 
> able to imaging how the struct looks like, whereas nothing (without 
> packed) might leave doubts which than requires to read compiler docs or 
> the generated code, if one searches a problem in that area.

I disagree.  If there are no annotations at all (no packed), there
should be no doubts.  The compiler will add padding wherever it is
needed for internal alignment and perhaps also at the end of the
structure.  Nowhere else.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/