linux-kernel - Re: [PATCH 0/4] PCI: fix cardbus and sriov regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E0353CA.7000708@hartkopp.net>
Date:	Thu, 23 Jun 2011 16:55:06 +0200
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Ram Pai <linuxram@...ibm.com>
CC:	yinghai@...nel.org, jbarnes@...tuousgeek.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] PCI: fix cardbus and sriov regressions

Hello RP,

unfortunately i noticed the discussion on linux-kernel ML a bit late, as i did
not subscribe it due to the traffic.

Did you get further with the unusual alignment?

Even if i did not see any problems (i did not test the CardBus slot but only
the sdhci_pci), i wonder if the register layout of some adapters would get
into problems with this alignment shown below?!?

Regards,
Oliver

ps. pls put me in CC in the next patch servies. tnx

On 21.06.2011 00:00, Oliver Hartkopp wrote:

>>>
>>> When comparing the logs with mgdiff, i found
>>>
>>> in revered:
>>>
>>> pci_bus 0000:04: resource 0 [io  0x2000-0x20ff]
>>> pci_bus 0000:04: resource 1 [io  0x2400-0x24ff]
>>>
>>> in the fixed version (4 patches)
>>>
>>> pci_bus 0000:04: resource 0 [io  0x2400-0x24ff]
>>> pci_bus 0000:04: resource 1 [io  0x2001-0x2100]
>>>
>>> Don't you think that the ressource 0x2001-0x2100 looks a bit weird?
>>>
>>> off-by-one problem?
>>
>> The resource location has slid by 1. That is because a reassign of
>> resource unfortunately does not let me realign it at the same location.
>>
>> ALIGN() macro is causing that weirdness.
>>
>> However is that slide by 1 causing you any problem?
> 
> No. I don't have a PCMCIA card here to test but the SD-Card is working
> properly. I just wondered about the unusual alignment ...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/