linux-kernel - Re: [RFC PATCH] futex: replace get_user_pages() with get_user_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1308843884.1022.142.camel@twins>
Date:	Thu, 23 Jun 2011 17:44:44 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Darren Hart <dvhart@...ux.intel.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	tglx@...utronix.de, linux-kernel@...r.kernel.org, mingo@...e.hu
Subject: Re: [RFC PATCH] futex: replace get_user_pages() with
 get_user_pages_fast()

On Thu, 2011-06-23 at 08:11 -0700, Darren Hart wrote:
> 
> On 06/22/2011 11:21 PM, KOSAKI Motohiro wrote:
> > Hello,
> > 
> > Is there any reason to take mmap_sem explicitly here?
> > Should we change gup_fast() to allow NULL argument (ie for avoid get_page)?
> > 
> > ============================
> >   down_read(&mm->mmap_sem);
> >   get_user_pages(current, current->mm)
> >   up_read(&mm->mmap_sem);
> > 
> > and
> > 
> >   get_user_pages_fast()
> > 
> > make an equivalent result, And latter would be better when mamp_sem
> > highly contended case, because it can avoid to take mmap_sem if
> > the target page doesn't need a page fault.
> 
> 
> I can't speak authoritatively here, but it seems to me that
> get_user_pages_fast falls back to get_user_pages with mmap_sem anyway,
> so this seems like a reasonable optimization for the best case, with a
> minor overhead for the slow case.
> 
> Peter, am I missing something? 

Right, its much cheaper on the fast-path where the page is found present
and writable, if we have to take the fault, the extra cost in the slow
path is neglectable.

> Is there a reason you left this as is
> during your fast gup futex update?

I probably completely missed this gup() user.

The proposed change looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/