linux-kernel - Re: linux-next: build warning after merge of the scsi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Jun 2011 10:02:39 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kiran Patil <kiran.patil@...el.com>,
	Joe Eykholt <jeykholt@...co.com>,
	Christoph Hellwig <hch@....de>, Yi Zou <yi.zou@...el.com>
Subject: Re: linux-next: build warning after merge of the scsi tree

On Thu, 19 May 2011 18:22:59 +0200 Geert Uytterhoeven wrote:

> On Wed, May 18, 2011 at 05:58, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >> --- a/drivers/target/tcm_fc/tfc_io.c
> >> +++ b/drivers/target/tcm_fc/tfc_io.c
> >> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
> >>                                                 "xid <0x%x>, remaining <0x%x>, "
> >>                                                 "lso_max <0x%x>\n",
> >>                                                 __func__, fp, ep->xid,
> >> -                                               remaining, lport->lso_max);
> >> +                                               (unsigned int)remaining,
> >> +                                               lport->lso_max);
> >
> > Given that "remaining" really is a length, surely it makes more sense to
> 
> Exactly my comments ...
> 
> > print it with %zd than to cast it and print it with %x ...
> 
> ... except that size_t is unsigned, so %zu would be a little bit better.


This still needs to be fixed in linux-next (20110623).

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/