linux-kernel - Re: [PATCH 09/15] xen/trace: add tlb flush tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308860628.531.42.camel@gandalf.stny.rr.com>
Date:	Thu, 23 Jun 2011 16:23:48 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Xen Devel <Xen-devel@...ts.xensource.com>,
	Ingo Molnar <mingo@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
Subject: Re: [PATCH 09/15] xen/trace: add tlb flush tracepoints

On Thu, 2011-06-23 at 12:52 -0700, Jeremy Fitzhardinge wrote:
> On 06/21/2011 07:07 AM, Konrad Rzeszutek Wilk wrote:
> >> +TRACE_EVENT(xen_mmu_flush_tlb,
> >> +	    TP_PROTO(int x),
> >> +	    TP_ARGS(x),
> >> +	    TP_STRUCT__entry(__array(char, x, 0)),
> >> +	    TP_fast_assign((void)x),
> >> +	    TP_printk("%s", "")
> > Um, why not just "" without the %s?
> 
> Uh, vararg macro bogusness; need to supply 2 args.
> 

Ouch! I didn't notice this before. Do you really need this empty event?
Why not just use the function tracer for this? It should work.

If you really need something like this, maybe I'll add a
DEFINE_EVENT_NOARGS() that will not require arguments and can eliminate
a lot of code that TRACE_EVENT() adds.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/